Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Fix RHEL.6 CI build #24331

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Fix RHEL.6 CI build #24331

merged 1 commit into from
Oct 2, 2017

Conversation

janvorli
Copy link
Member

@janvorli janvorli commented Sep 29, 2017

I have missed msbuild options separator in the build.sh
invocation when adding the /p:PortableBuild=false option. I have also missing the -runtimeos option at all scripts invocations.

@janvorli janvorli added area-Infrastructure-libraries bug Product bug (most likely) labels Sep 29, 2017
@janvorli janvorli self-assigned this Sep 29, 2017
@janvorli
Copy link
Member Author

@dotnet-bot test CentOS.6 x64 Release Build

@janvorli
Copy link
Member Author

@dotnet-bot test CentOS.6 x64 Release Build

I have missed msbuild options separator in the build.sh
invocation when adding the /p:PortableBuild=false option.
@janvorli
Copy link
Member Author

@dotnet-bot test CentOS.6 x64 Release Build

@janvorli janvorli requested a review from mmitche September 29, 2017 17:52
@janvorli
Copy link
Member Author

@dotnet-bot test OSX x64 Debug Build please

@janvorli
Copy link
Member Author

janvorli commented Oct 2, 2017

@mmitche can you take a look please?

@janvorli janvorli merged commit df8e3b5 into dotnet:master Oct 2, 2017
@janvorli janvorli deleted the fix-rhel6-ci branch October 2, 2017 15:05
@karelz karelz added this to the 2.1.0 milestone Oct 11, 2017
pjanotti pushed a commit to pjanotti/corefx that referenced this pull request Oct 31, 2017
I have missed msbuild options separator in the build.sh
invocation when adding the /p:PortableBuild=false option.
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request May 2, 2019
…ew type (dotnet#24331)

We decided after all to put these on a different type, TaskAsyncEnumerableExtensions.  This commit adds the new type.  We can delete the methods in the old location once corefx consumes an updated build and switches over to using the new ones.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Anipik pushed a commit that referenced this pull request May 2, 2019
…ew type (#24331)

We decided after all to put these on a different type, TaskAsyncEnumerableExtensions.  This commit adds the new type.  We can delete the methods in the old location once corefx consumes an updated build and switches over to using the new ones.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
I have missed msbuild options separator in the build.sh
invocation when adding the /p:PortableBuild=false option.

Commit migrated from dotnet/corefx@df8e3b5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries bug Product bug (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants